Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paradox error for discard entity bytes #1944

Merged
merged 1 commit into from Mar 19, 2018
Merged

Conversation

chbatey
Copy link
Member

@chbatey chbatey commented Mar 16, 2018

I couldn't work out why this was rendering as
"Sink]@java[response.discardEntityBytes(Materializer)`]" in
https://doc.akka.io/docs/akka-http/current/client-side/request-level.html

This fixes it and I think it reads slightly better.

I couldn't work out why this was rendering as
"Sink]@java[response.discardEntityBytes(Materializer)`]" in
https://doc.akka.io/docs/akka-http/current/client-side/request-level.html

This fixes it and I think it reads slightly better.
@akka-ci akka-ci added validating PR that is currently being validated by Jenkins tested PR that was successfully built and tested by Jenkins and removed validating PR that is currently being validated by Jenkins labels Mar 16, 2018
@akka-ci
Copy link

akka-ci commented Mar 16, 2018

Test PASSed.

Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising indeed, I guess it parses @unidoc[Sink] (...) as one thing even with the whitespace between the ] and (. But I agree the new wording is clearer anyway!

@ktoso ktoso merged commit 09213ff into akka:master Mar 19, 2018
@ktoso ktoso added this to the 10.1.1 milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR that was successfully built and tested by Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants