Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDSL Unmarshaller is leaking ScalaDSL classes #604

Closed
jlprat opened this issue Dec 1, 2016 · 3 comments
Closed

JavaDSL Unmarshaller is leaking ScalaDSL classes #604

jlprat opened this issue Dec 1, 2016 · 3 comments
Labels
bug help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL
Projects
Milestone

Comments

@jlprat
Copy link
Member

jlprat commented Dec 1, 2016

The current akka.http.javadsl.unmarshalling.Unmarshaller is leaking some scaladsl as return types. The current examples I found are:

  • entityToMultipartByteRanges() that is returning Unmarshaller<http.javadsl.model.HttpEntity, akka.http.scaladsl.model.Multipart.ByteRanges>
  • entityToUrlEncodedFormData() that is returning Unmarshaller<http.javadsl.model.HttpEntity, akka.http.scaladsl.model.FormData>
@ktoso
Copy link
Member

ktoso commented Dec 1, 2016

Thanks for catching it, that's a bug / missing API that needs ot be fixed.
It is possible that we're missing those datatypes in javadsl... :/

Would you give it an attempt to fix?

@ktoso ktoso added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted binary-incompatible bug help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL and removed binary-incompatible labels Dec 1, 2016
@jlprat
Copy link
Member Author

jlprat commented Dec 1, 2016

Sure!

@ktoso
Copy link
Member

ktoso commented Jan 5, 2017

Thanks @jlprat !

@ktoso ktoso closed this as completed Jan 5, 2017
@ktoso ktoso modified the milestones: 10.0.x, 10.0.2 Jan 5, 2017
@ktoso ktoso removed the 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help wanted Identifies issues that the core team will likely not have time to work on t:java Issues related to the Java DSL
Projects
No open projects
Development

No branches or pull requests

2 participants