JavaDSL Unmarshaller is leaking ScalaDSL classes #604

Closed
jlprat opened this Issue Dec 1, 2016 · 3 comments

Projects

Done in Bug Hunting

2 participants

@jlprat
Contributor
jlprat commented Dec 1, 2016

The current akka.http.javadsl.unmarshalling.Unmarshaller is leaking some scaladsl as return types. The current examples I found are:

  • entityToMultipartByteRanges() that is returning Unmarshaller<http.javadsl.model.HttpEntity, akka.http.scaladsl.model.Multipart.ByteRanges>
  • entityToUrlEncodedFormData() that is returning Unmarshaller<http.javadsl.model.HttpEntity, akka.http.scaladsl.model.FormData>
@ktoso
Member
ktoso commented Dec 1, 2016

Thanks for catching it, that's a bug / missing API that needs ot be fixed.
It is possible that we're missing those datatypes in javadsl... :/

Would you give it an attempt to fix?

@jlprat
Contributor
jlprat commented Dec 1, 2016

Sure!

@ktoso
Member
ktoso commented Jan 5, 2017

Thanks @jlprat !

@ktoso ktoso closed this Jan 5, 2017
@ktoso ktoso modified the milestone: 10.0.x, 10.0.2 Jan 5, 2017
@ktoso ktoso removed the 1 - triaged label Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment