doc: Correction of rbac api group for AppVersionRevision #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
May 19, 2023
patriknw
commented
- pods is in core "" api group
- replicasets is in "apps" api group
* pods is in core "" api group * replicasets is in "apps" api group
patriknw
commented
May 19, 2023
| resources: ["pods"] # access to get replicaset | ||
| verbs: ["get", "list"] | ||
| - apiGroups: ["apps"] | ||
| resources: ["replicasets"] # access to get revision annotation |
There was a problem hiding this comment.
it works to define it as ["apps", ""] but it's rather confusing
patriknw
commented
May 19, 2023
| @@ -296,7 +296,7 @@ PUTs must contain resourceVersions. Response: | |||
| Unmarshal(response.entity) | |||
| .to[String] | |||
| .map(body => | |||
| throw new PodCostException( | |||
| throw new UnauthorizedException( | |||
There was a problem hiding this comment.
doesn't matter what exception is used here, but since handleUnauthorized is also used for the revision
efgpinto
approved these changes
May 19, 2023
| resources: ["pods"] # access to get replicaset | ||
| verbs: ["get", "list"] | ||
| - apiGroups: ["apps"] | ||
| resources: ["replicasets"] # access to get revision annotation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.