New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legacyTagKey does not maintain the legacy schema layout #825
Comments
Looking through the implementation, I think that the migration docs were just not right. Looking at this comment, it gives the impression that the schema is actually intended to be changed (two columns added) without taking advantage of the improvements (which is
I assume this works since the query part does truly maintain the legacy schema layout by only looking at the Waiting for additional feedback if this issue just ends up needing to fix the migration docs, or if we need a fix in the implementation to not insert into the two additional columns in the legacy-tag-key mode. |
I did not find a good way to have a runtime-migration between the old and new schema which would allow a non-downtime migration to the non-legacy tag approach. I think we should revert the default code path and schema to what is was pre 5.4.0, and then add explicit docs to explain how to go to the non-legacy tag mode - which requires a downtime. Alternative: add to the docs that adding the two columns is required - which feels bad in a non-major release. |
I don't think it will require downtime. That was the whole intention of the effort in adding the config flags. I think it's already possible to do a multi-phase rolling update, but it requires that the two columns are added as the first thing while it's running the old version. I agree that it's unfortunate to require adding those columns. |
This contribution introduced a new column
persistence_id
in theevent_tag
table. Also, a new flaglegacyTagKey
got introduced which was intended default to the backward compatibility code path that works without the new column.However, looking at this section shows that regardless of the value of
legacyTagKey
apersistenceId
gets written. In the default case (legacyTagKey=trure
) there is no such column.The text was updated successfully, but these errors were encountered: