Use bulk update API for shard allocation #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ennru
reviewed
Jul 7, 2020
| @@ -9,7 +9,7 @@ val Nightly = sys.env.get("TRAVIS_EVENT_TYPE").contains("cron") | |||
| val Scala211 = "2.11.12" | |||
| val Scala212 = "2.12.10" | |||
| val Scala213 = "2.13.1" | |||
| val akkaVersion26 = "2.6.3" | |||
| val akkaVersion26 = "2.6.6" | |||
There was a problem hiding this comment.
Is this upgrade is required? If not we'd keep 2.6.3.
Aboid multiple ddata round trips
|
The new API is not in 2.6.3 but I could check what the min upgrade could be
if that helps? But if we’re upgrading maybe we should just go to 2.6.6
…On Tue, 7 Jul 2020 at 11:26, Enno ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In build.sbt
<#1139 (comment)>:
> @@ -9,7 +9,7 @@ val Nightly = sys.env.get("TRAVIS_EVENT_TYPE").contains("cron")
val Scala211 = "2.11.12"
val Scala212 = "2.12.10"
val Scala213 = "2.13.1"
-val akkaVersion26 = "2.6.3"
+val akkaVersion26 = "2.6.6"
Is this upgrade is required? If not we'd keep 2.6.3.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1139 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOHYG7NPCCKQ52Y2EZKQGTR2LZ5DANCNFSM4OSQ2DGQ>
.
|
|
Yes, when we update we go all the way. |
ennru
force-pushed
the
wip-chbatey-use-bulk-update
branch
from
f3dbafb
to
fddc156
Compare
|
Unrelated build failure: #1070 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1138