Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka typed first documentation user experience #1370

Merged
merged 8 commits into from May 14, 2021

Conversation

seglo
Copy link
Member

@seglo seglo commented May 13, 2021

References #984

}
//#withTypedRebalanceListenerActor

val guardian: Behavior[Nothing] = Behaviors.setup[Nothing] { context =>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tabbing is weird to line up columns in docs. Is there a better way?

@seglo
Copy link
Member Author

seglo commented May 14, 2021

@ennru I haven't gone through all the docs yet, but is this what you had in mind for updating the docs for a Akka 2.6 (typed) first experience?

build.sbt Outdated Show resolved Hide resolved
@seglo seglo changed the title Typed ActorRef APIs Akka typed first documentation user experience May 14, 2021
@seglo seglo requested review from ennru and patriknw May 14, 2021 18:11
@seglo seglo marked this pull request as ready for review May 14, 2021 18:12
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but javafmt doesn't like it.

@seglo
Copy link
Member Author

seglo commented May 14, 2021

javafmt can take a hike!

@seglo seglo merged commit 0b44b31 into akka:master May 14, 2021
@seglo seglo deleted the seglo/akka-26-docs branch May 14, 2021 20:09
@seglo seglo added this to the 2.1.0 milestone May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants