Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Opt-in Metrics measurement #19

Open
to11mtm opened this issue Feb 6, 2021 · 0 comments
Open

Add Opt-in Metrics measurement #19

to11mtm opened this issue Feb 6, 2021 · 0 comments

Comments

@to11mtm
Copy link
Member

to11mtm commented Feb 6, 2021

It would be nice to add some Metrics measurement capabilities.

We should look for:

  • 'Opt in' behavior such that if metrics are disabled, the performance difference from before/after PR is negligible.
  • Tracking of number of rows written in an operation (so that rows/sec may be measured)
  • Time of operations:
    • read, write, delete

Questions:

  • How do we want to let these metrics be observed?
    • Possibly an interface?
      • If people want Eventstream, they can wrap from that.
      • If people want direct, they can do that too.
  • How granular do we want to be? DB RoundTrips are definitely on the menu, but should we also measure total operation time?
    • (example, when ReplayMessagesAsync has to make multiple round trips, do we report that as well as a separate metric?)
  • Should we metric errors?
    • may be useful for scenarios where a RetryPolicy is defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant