Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQP Source manual ack #20

Closed
vasily-kirichenko opened this issue Jan 16, 2018 · 1 comment
Closed

AMQP Source manual ack #20

vasily-kirichenko opened this issue Jan 16, 2018 · 1 comment

Comments

@vasily-kirichenko
Copy link
Contributor

vasily-kirichenko commented Jan 16, 2018 •
edited

Current implementation acks messages as soon as it pushed them downstream, which is not what I want. I need to be on control of acking each message manually, in some of downstream stages or outside the stream (e.g. in an independent actor):

https://github.com/AkkaNetContrib/Alpakka/blob/1a6a51c562e44143d0eb0f1cb175316494ed0d6a/Amqp/src/Akka.Streams.Amqp/AmqpSourceStage.cs#L136

Scala Alpakka was added CommittableMessage more that a year ago in akka/alpakka@d478a61, see discussion akka/alpakka#97

https://github.com/akka/alpakka/blob/453809a489b37963dc0395ab37db20fd2963a3fe/amqp/src/main/scala/akka/stream/alpakka/amqp/AmqpSourceStage.scala#L95-L109
@vasily-kirichenko
Copy link
Contributor Author

WIP #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vasily-kirichenko