Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actor reference leak in AddressTerminatedTopic #4304

Closed
petrikero opened this issue Mar 9, 2020 · 2 comments · Fixed by #4305 or #4308
Closed

Actor reference leak in AddressTerminatedTopic #4304

petrikero opened this issue Mar 9, 2020 · 2 comments · Fixed by #4305 or #4308
Labels
Milestone

Comments

@petrikero
Copy link
Contributor

In case where actor A, that is being watched by remote actor B, terminates immediately after being unwatched by B, there is a chance the AddressTerminatedTopic leaks a reference to A.

The issue arises due to TellWatchersWeDied() clearing the incorrect "watching" list when it should clear the watchedBy list in its finally block. Also, the clearing should be wrapped in a MaintainAddressTerminatedSubscription().

For reference, original Akka already implements the proposed change.

I have a pending fix for this and will make a PR.

Using Akka.Net version 1.3.17, though bug seems to have been there for years. Bug appears on Windows and dockerized Linux. I don't have a simple repro, but am seeing it in a larger system.

@petrikero
Copy link
Contributor Author

@petrikero
Copy link
Contributor Author

Here's a link to the PR as well: #4305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment