Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akka.Pattern: Pass in clearer error message into OpenCircuitException #4314

Closed
Aaronontheweb opened this issue Mar 9, 2020 · 1 comment · Fixed by #4534
Closed

Akka.Pattern: Pass in clearer error message into OpenCircuitException #4314

Aaronontheweb opened this issue Mar 9, 2020 · 1 comment · Fixed by #4534

Comments

@Aaronontheweb
Copy link
Member

Akka.NET Version: 1.4.1-rc1 and later

When an Akka.Persistence journal begins experiencing failures on the database-side of the operation, users begin seeing lots of OpenCircuitExceptions appear inside their logs - these errors don't do much to tell the human operators of Akka.NET clusters and applications what is really going on under the covers and what the root cause of the issue is.

If we could add some method overloads to CircuitBreaker to make it possible to provide a hint as to what's going on, that would be very useful for operators.

@ismaelhamed
Copy link
Member

ismaelhamed commented Mar 14, 2020

I've had this conversation so many times. Because only the very first exception will actually give you some insight, and everything after that is just failing fast.

One possible solution could be to make the CircuitBreaker remember the last exception (which made the circuit to break) and set it as the InnerException of the OpenCircuitException

@Aaronontheweb Aaronontheweb modified the milestones: 1.4.3, 1.4.4 Mar 18, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.4, 1.4.5 Mar 31, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.5, 1.4.6 Apr 29, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.6, 1.4.7 May 12, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.7, 1.4.8 May 26, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.8, 1.4.9 Jun 17, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.9, 1.4.10 Jul 21, 2020
This was referenced Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants