No connection string for Sql Event Journal was specified

[ismaelhamed]

Akka: 1.4.2 (but might be affecting more versions)

Looks like the preprocessor directive CONFIGURATION is not defined for NETStandard, which in this case is preventing from loading the connection-string-name from configuration.

akka.net/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/BatchingSqlJournal.cs

Line 258 in 345c601

#if CONFIGURATION

[Aaronontheweb]

thanks for reporting this are you planning on submitting a PR? If so, we'll do a new 1.4.3 release ASAP.

[ismaelhamed]

Maybe there's more to it than I anticipated.

If I'm not mistaken, the following code will only retrieve the connetionString from an app.config, but what if this was an ASP.NET Core using an appsettings.json? Wouldn't we need to use Microsoft.Extensions.Configuration instead in that case?

akka.net/src/contrib/persistence/Akka.Persistence.Sql.Common/Journal/BatchingSqlJournal.cs

Lines 258 to 265 in 345c601

	#if CONFIGURATION
	if (string.IsNullOrWhiteSpace(connectionString))
	{
	connectionString = System.Configuration.ConfigurationManager
	.ConnectionStrings[config.GetString("connection-string-name", "DefaultConnection")]
	.ConnectionString;
	}
	#endif

[Arkatufus]

The CONFIGURATION compiler directive is App.config specific, Microsoft.Extensions.Configuration support is on the development road map, but it won't be implemented just yet.