Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to make PersistenceMessageSerializer version tolerant #5001

Open
Aaronontheweb opened this issue May 10, 2021 · 2 comments · May be fixed by #5002
Open

Need to make PersistenceMessageSerializer version tolerant #5001

Aaronontheweb opened this issue May 10, 2021 · 2 comments · May be fixed by #5002

Comments

@Aaronontheweb
Copy link
Member

Version: v1.4.19

Right now our PersistenceMessageSerializer isn't using type manifests for its message names:

https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Persistence/Serialization/PersistenceMessageSerializer.cs

We need to perform the same type of transformation we just applied to the #4989 in order to preserve backwards compatibility with previously serialized message types while also decoupling any future changes to the internal type names from the manifests we use inside the persistence payloads.

Before we release v1.4.20 we will need to make sure this change is compatibility-tested against Akka.Persistence.SqlServer and its nightly builds.

@Arkatufus
Copy link
Contributor

This issue is nastier than it looks, problem with the Akka.Persistence.Fsm.PersistentFSM.PersistentFSMSnapshot class being a generic class, making it really hard to hard code a manifest string and create a hard coded backward compatibility manifest for this class.

@Aaronontheweb
Copy link
Member Author

This issue is nastier than it looks, problem with the Akka.Persistence.Fsm.PersistentFSM.PersistentFSMSnapshot class being a generic class, making it really hard to hard code a manifest string and create a hard coded backward compatibility manifest for this class.

That is nasty....

@Aaronontheweb Aaronontheweb modified the milestones: 1.4.20, 1.4.21 May 12, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.21, 1.4.22 Jun 16, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.22, 1.4.23, 1.4.24 Aug 5, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.24, 1.4.25 Aug 18, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.25, 1.4.26 Sep 8, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.26, 1.4.27 Sep 28, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.27, 1.4.28 Oct 11, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.28, 1.4.29 Nov 10, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.29, 1.4.30 Dec 13, 2021
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.30, 1.4.31 Dec 20, 2021
@Aaronontheweb Aaronontheweb added this to the 1.4.36 milestone Mar 18, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.36, 1.4.37, 1.4.38 Apr 14, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.38, 1.4.39 May 25, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.39, 1.4.40 Jun 1, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.40, 1.4.41 Jul 27, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.41, 1.4.42 Sep 7, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.42, 1.4.43, 1.4.44 Sep 23, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.44, 1.4.45, 1.4.46 Oct 17, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.46, 1.4.47 Nov 15, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.47, 1.4.48 Dec 9, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.48, 1.4.49 Jan 5, 2023
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.49, 1.4.50 Jan 26, 2023
@Aaronontheweb Aaronontheweb removed this from the 1.4.50 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants