Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker-based integration test infrastructure #14

Closed
heynickc opened this issue Sep 6, 2017 · 5 comments
Closed

Add docker-based integration test infrastructure #14

heynickc opened this issue Sep 6, 2017 · 5 comments
Assignees

Comments

@heynickc
Copy link

heynickc commented Sep 6, 2017

To be consistent with SqlServer, Postgres, Cassandra plugins, test against a container running MySql

@heynickc heynickc self-assigned this Sep 6, 2017
@alexvaluyskiy
Copy link
Contributor

@heynickc Not necessary. We have AppVeyor CI and it worked for integration tests before. I have to realize why it stopped working

@heynickc
Copy link
Author

heynickc commented Sep 6, 2017

@alexvaluyskiy this is an additional feature, not a bug fix. this is how we test our other plugins against live databases to allow integration testing against different versions of the databases

@heynickc
Copy link
Author

heynickc commented Sep 6, 2017

@alexvaluyskiy if you would like to discontinue testing our persistence plugins this way, please bring it up with the core team to reach a consensus and we will discontinue testing this way across all plugins

@Aaronontheweb
Copy link
Member

@alexvaluyskiy better off standardizing on Docker

@heynickc
Copy link
Author

heynickc commented Sep 6, 2017

disregard, since this is a contrib package now

@heynickc heynickc closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants