Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the default starter project modifying src/popup.ts closes the browser and never reopens it #172

Closed
antitoxic opened this issue Dec 26, 2023 · 1 comment · Fixed by #173
Labels
pending triage Report that needs looked at

Comments

@antitoxic
Copy link

Summary

I created a empty starter project (vanilla ts) via pnpm create vite-plugin-web-extension and I modified popup.ts but the browser simply closed and never re-opened.

Reproduction

  • pnpm create vite-plugin-web-extension
  • pnpm install
  • pnpm dev
  • Modify src/popup.ts
  • Now the browser closes but never reopens. I also expected a change to popup.ts wouldn't cause a browser restart but simply HMR

Environment

  System:
    OS: macOS 13.0
    CPU: (10) arm64 Apple M2 Pro
    Memory: 53.23 MB / 16.00 GB
    Shell: 3.6.4 - /opt/homebrew/bin/fish
  Binaries:
    Node: 18.15.0 - ~/pnpm/node
    npm: 9.5.0 - ~/pnpm/npm
    pnpm: 8.12.1 - ~/pnpm/pnpm
  Browsers:
    Chrome: 120.0.6099.129
    Safari: 16.1
  npmPackages:
    vite: ^5.0.0 => 5.0.10
    vite-plugin-web-extension: ^4.0.0 => 4.1.0
@antitoxic antitoxic added the pending triage Report that needs looked at label Dec 26, 2023
@aklinker1
Copy link
Owner

Fixed in v4.1.1. Thanks for the report, let me know if it doesn't work for you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending triage Report that needs looked at
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants