Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Inconsistent code style in effect and param classes #27

Open
akmadian opened this issue Feb 28, 2019 · 0 comments
Open

Inconsistent code style in effect and param classes #27

akmadian opened this issue Feb 28, 2019 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed Todo

Comments

@akmadian
Copy link
Owner

  • Mixed brackets style

    • Want on new line after method/ statement
    • Want no brackets on one line ifs/ loops/ etc.

  • Variable naming

    • Make variable names in effect buildbytes methods device specific; KrakenXSettingsBytes/ HuePlusSettingsBytes.
@akmadian akmadian added help wanted Extra attention is needed good first issue Good for newcomers Todo labels Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed Todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akmadian