Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode AWS credentials in the script #3

Open
ghost opened this issue Aug 18, 2015 · 1 comment
Open

Don't hardcode AWS credentials in the script #3

ghost opened this issue Aug 18, 2015 · 1 comment

Comments

@ghost
Copy link

ghost commented Aug 18, 2015

Hardcoding the credentials like this
if args.account == 'zabbix':
aws_key = 'YOUR_AWS_KEY_GOES_HERE'
aws_secret = 'YOU_AWS_SECRET_GOES_HERE'
is a bad practice. Why don't you remove the credentials altogether and don't you let boto handle it itself using http://boto.readthedocs.org/en/latest/boto_config_tut.html ?

@akomic
Copy link
Owner

akomic commented Aug 19, 2015

That's how it was implemented initially and doesn't change much if the credentials are kept in .py file or in separate file in the same place. If credentials are kept in keyring that would be the improvement. Can you do the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant