Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

commit doesn't work after update #371

Closed
SlimeQ opened this issue Jan 12, 2016 · 4 comments
Closed

commit doesn't work after update #371

SlimeQ opened this issue Jan 12, 2016 · 4 comments

Comments

@SlimeQ
Copy link

SlimeQ commented Jan 12, 2016

i updated git-plus today and i can no longer commit from git-plus.

Ubuntu 14.04
atom 1.3.0

@dustb0wl
Copy link

Same thing here - throwing an empty commit message error. Uninstall / reinstall had no effect

OSX 10.10.5
Atom 1.3.3

@akonwi akonwi closed this as completed in afee7ac Jan 13, 2016
@akonwi
Copy link
Owner

akonwi commented Jan 13, 2016

Sorry y'all. It seems there are some problems I need to dig deeper into with commits that are preventing making #90 a reality. I'm glad they were caught quickly

@SlimeQ
Copy link
Author

SlimeQ commented Jan 13, 2016

it really screws my world up when this package breaks. just out of curiosity, why didn't the tests in /spec catch this?

@akonwi
Copy link
Owner

akonwi commented Jan 15, 2016

@SlimeQ I don't have details about what went wrong for you two. The tests are reflections of how I use this package. Unfortunately, unit tests themselves aren't enough for testing every possible scenario of usage. I do some dog-fooding and use the latest changes of the package so I can do some manual testing and get a feel for the actual usage of the package. Even that isn't enough sometimes because I don't do the same things everyone else might do and I won't reproduce a lot things.

It'd be great if I had some beta testers that could use features in a dev branch before they were published so these issues were caught before they met the rest of the user base. I'm going to spend some time thinking of a way to explore that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants