Improve status-bar icon behaviour

[danielbayley]

• Fix tooltip
• Add option to disable status bar icon

[akonwi]

An issue that has been raised multiple times in the past is that the output view disappears too quickly. Declaring a keybinding (from this package) to toggle its visibility doesn't seem valuable in my opinion.

There will be users who disable that icon toggle and open issues about not being able to view the output. Do you have a secondary way to toggle it if the icon is disabled? If there is a command exposed from the package that users could bind to, I think that would be great.

I'll take the changes for the tooltip for now though and hold on the disable option.

[danielbayley]

Yeah cool. 👍

So other packages that output to a bottom panel just leave it open until closed manually (either with esc or a close icon in the panel itself).

This is a much better UX than further cluttering up the status bar with more icons… (maybe I just don’t like the pin icon 😄) so I think this package should be consistent with that behaviour…

If there is a command exposed from the package that users could bind to, I think that would be great.

Doesn’t clicking the pin already call some kind of git-plus:toggle-output-console command?

[akonwi]

The problem I've seen with people trying to bind to the escape key in this package is that we'll often click or do something else which removes focus from the panel and then hitting escape will be triggered from a different element. There have been other attempts at combining escape with other keys like shift which also haven't worked.

The click actually toggles directly so that command does not exist yet