Improve branch list status-bar item and modal

[danielbayley]

• Change current to HEAD branch list indicator
• Add git-branch to class list of branches modal
• Allow other packages to use branch status-bar item

[danielbayley]

This package doesn’t get activated until one of it’s commands is called (which is obviously good for overall performance), but clicking on the branch list in the status-bar doesn’t currently activate it, when I think it should.

@akonwi Any thoughts on how that could work without removing the list of "activationCommands": from package.json?

[akonwi]

Is there styling that uses this class name? This name is being used by atom already so we should be careful of clashing of styles

[danielbayley]

Is there styling that uses this class name?

Yeah, a theme I am working on for one, which adds icons to the modals. Packages often don’t bother to add a class to them, with the result being the inability to target them individually for styling.

With this line the class selector becomes .select-list.git-branch or atom-panel .modal .select-list.git-branch to be more specific, so shouldn’t be a problem unless I’m missing something? (Working fine on my local fork…)

[akonwi]

Sounds good. Must be a cool theme! Is it available yet?

[akonwi]

The only other option I can think of at this point is to make a change to atom's status-bar package to try and activate git-plus on click. I'm not sure how receptive they will be to that.

[danielbayley]

I'm not sure how receptive they will be to that.

Probably not very… I don’t think core packages should be arbitrarily dealing with other packages like that either.

They already have this related PR also.

Surely there must be a way to do this from this package?

[akonwi]

I don't think we can activate the package from within itself aside from removing the activationCommands like you mentioned