Deprecated selector in git-plus/styles/git-plus.less

[molovo]

In git-plus/styles/git-plus.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

• atom-text-editor .diff .unimportant, atom-text-editor::shadow .diff .unimportant => atom-text-editor .diff .unimportant, atom-text-editor.editor .syntax--diff .syntax--unimportant

• atom-text-editor .diff .info, atom-text-editor::shadow .diff .info => atom-text-editor .diff .info, atom-text-editor.editor .syntax--diff .syntax--info

• atom-text-editor .diff .deletion, atom-text-editor::shadow .diff .deletion => atom-text-editor .diff .deletion, atom-text-editor.editor .syntax--diff .syntax--deletion

• atom-text-editor .diff .insertion, atom-text-editor::shadow .diff .insertion => atom-text-editor .diff .insertion, atom-text-editor.editor .syntax--diff .syntax--insertion

• atom-text-editor .diff .markup.removed.diff, atom-text-editor::shadow .diff .markup.removed.diff, atom-text-editor .diff .meta.diff.header.from-file, atom-text-editor::shadow .diff .meta.diff.header.from-file => atom-text-editor .diff .markup.removed.diff, atom-text-editor.editor .syntax--diff .syntax--markup.syntax--removed.syntax--diff, atom-text-editor .diff .meta.diff.header.from-file, atom-text-editor.editor .syntax--diff .syntax--meta.syntax--diff.syntax--header.syntax--from-file

• atom-text-editor .diff .markup.added.diff, atom-text-editor::shadow .diff .markup.added.diff, atom-text-editor .diff .meta.diff.header.to-file, atom-text-editor::shadow .diff .meta.diff.header.to-file => atom-text-editor .diff .markup.added.diff, atom-text-editor.editor .syntax--diff .syntax--markup.syntax--added.syntax--diff, atom-text-editor .diff .meta.diff.header.to-file, atom-text-editor.editor .syntax--diff .syntax--meta.syntax--diff.syntax--header.syntax--to-file

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

[akonwi]

i've pushed changes for this. Can you validate this has been resolved?

[molovo]

The vast majority of the deprecation warnings are gone, but this line still has the atom-text-editor::shadow declaration, which needs to be replaced with atom-text-editor.editor. I'll PR it now.

Nevermind, I just realised you added the correct selectors below, so it should work in both versions. That's a nice idea by the way

[akonwi]

Thanks! Ok I'll keep this open for a while and if you come across more errors related to these selectors we can tackle them.

[klk1010]

I'm still seeing deprecation warnings in v 7.0.4.

git-plus/styles/git-plus.less
Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

atom-text-editor .diff .unimportant, atom-text-editor::shadow .diff .unimportant => atom-text-editor .diff .unimportant, atom-text-editor.editor .syntax--diff .syntax--unimportant
atom-text-editor .diff .info, atom-text-editor::shadow .diff .info => atom-text-editor .diff .info, atom-text-editor.editor .syntax--diff .syntax--info
atom-text-editor .diff .deletion, atom-text-editor::shadow .diff .deletion => atom-text-editor .diff .deletion, atom-text-editor.editor .syntax--diff .syntax--deletion
atom-text-editor .diff .insertion, atom-text-editor::shadow .diff .insertion => atom-text-editor .diff .insertion, atom-text-editor.editor .syntax--diff .syntax--insertion
atom-text-editor .diff .markup.removed.diff, atom-text-editor::shadow .diff .markup.removed.diff, atom-text-editor .diff .meta.diff.header.from-file, atom-text-editor::shadow .diff .meta.diff.header.from-file => atom-text-editor .diff .markup.removed.diff, atom-text-editor.editor .syntax--diff .syntax--markup.syntax--removed.syntax--diff, atom-text-editor .diff .meta.diff.header.from-file, atom-text-editor.editor .syntax--diff .syntax--meta.syntax--diff.syntax--header.syntax--from-file
atom-text-editor .diff .markup.added.diff, atom-text-editor::shadow .diff .markup.added.diff, atom-text-editor .diff .meta.diff.header.to-file, atom-text-editor::shadow .diff .meta.diff.header.to-file => atom-text-editor .diff .markup.added.diff, atom-text-editor.editor .syntax--diff .syntax--markup.syntax--added.syntax--diff, atom-text-editor .diff .meta.diff.header.to-file, atom-text-editor.editor .syntax--diff .syntax--meta.syntax--diff.syntax--header.syntax--to-file
Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

[molovo]

@klk1010 The old and new selectors are both present in the CSS, to preserve backward compatibility

[klk1010]

@molovo Indeed they are. I apologize for not looking at that more closely. :insert_shamed_face_here:

[Robin-front]

atom1.13.0 mac also

[akonwi]

@Robin-front thanks! I was waiting for 1.13 to come out. Now I can remove the old selectors and restrict the package to the newest version of atom that doesn't support the shadow selectors

[jesusvallez]

mac here! atom 1.13.0