You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Currently, if you try and use git-plus with a repository that has a pre-configured git pre-commit hook, and you take the time to write out a nice long commit message, the message is completely lost if the pre-commit hook fails.
Steps to reproduce:
Copy paste this stuff into bash to setup the test case:
Now type some stuff in atom, and hit CTRL+s to save
Now type CTRL+SHIFT+A a to "Git add all and commit"
Add a commit message to the newly minted COMMIT_EDITMSG pane
Finally, press CTRL+s again to save the message (pane disappears)
Observe the failure and how the commit 1. fails 2. message is not retained anywhere
The way git proper handles this on the commandline is by running the pre-commit hook before it asks for a message.
If you're like me and forget sometimes where you have pre-commit hooks in place, and you're like me and write out lengthy messages - this is a serious bug/annoyance to have to re-write everything you just worked hard to explain.
The text was updated successfully, but these errors were encountered:
Git will run the hook before asking for a message if no arguments are passed with git commit.
Commits are handled by the package by passing the file, in which you've written the commit message into, to the commit command in the shell with git commit --file path/to/COMMIT_EDITMSG. After everything finishes, regardless of success, the COMMIT_EDITMSG file gets deleted. Perhaps it is better to keep the file or cache the failed commit message so it is easily retrievable.
This is not an enhancement, but a bug.
Currently, if you try and use git-plus with a repository that has a pre-configured git pre-commit hook, and you take the time to write out a nice long commit message, the message is completely lost if the
pre-commit
hook fails.Steps to reproduce:
CTRL+s
to saveCTRL+SHIFT+A a
to "Git add all and commit"COMMIT_EDITMSG
paneCTRL+s
again to save the message (pane disappears)The way
git
proper handles this on the commandline is by running thepre-commit
hook before it asks for a message.If you're like me and forget sometimes where you have
pre-commit
hooks in place, and you're like me and write out lengthy messages - this is a serious bug/annoyance to have to re-write everything you just worked hard to explain.The text was updated successfully, but these errors were encountered: