Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommended changes resulting from automated audit #15

Closed
5 tasks done
Jericho opened this issue Jun 5, 2018 · 1 comment
Closed
5 tasks done

Recommended changes resulting from automated audit #15

Jericho opened this issue Jun 5, 2018 · 1 comment

Comments

@Jericho
Copy link

Jericho commented Jun 5, 2018

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.26.1. Please upgrade to 0.28.0
  • You are currently referencing Cake.Common 0.26.1. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • The Cake.Common reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Common" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

@akordowski
Copy link
Owner

Updated the addin to Cake 0.29.0. Cannot target netstandard2.0 because the dependent SharpZipLib currently don't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants