Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpredictable behaviour after successive runs using Previous button #454

Open
chookster opened this issue Feb 26, 2023 · 5 comments
Open
Labels
bug Something isn't working

Comments

@chookster
Copy link

chookster commented Feb 26, 2023

v5.0.6 and v5.0.7

Hi Akos... I have noticed some unpredictable outcomes after successive Yarle export runs where the 'Previous' button is used to step back and change options, rather than do a fresh start of Yarle each time. So far, there are two of these outcomes that have repeated themselves.
1. Exporting a single .enex notebook containing 6 notes, only 2 notes will be successively exported. This can occur after changing the Attachment directory options on the Configuration page. It usually doesn't happen after the first change and might take several export runs with changes to the Attachment directory options in between runs before it occurs.
2. Exporting a batch of 11 .enex notebooks containing 397 notes, the Attachments directory will be written to the location set in a previous run, rather than the latest location specified on the Configuration page. Again, this seems to take several changes of Attachment directory options to trigger the outcome.

So both outcomes seem to be related to changing the Attachment directory location by using the Previous button. Maybe Yarle is not intended to be reconfigured successively using the Previous button and so this is my error. I was hoping to be able to give you a repeatable formula for re-creating these outcomes, but the issues can occur after one run or five runs. Perhaps you may be able to spot the source of the issue from the description above.

Later...
I have just run a number of exports with Yarle 5.0.7 and the single .enex notebook containing 6 notes. Both issues 1 and 2 described above have occurred.

Attached is a set of files relating to issue 1. In this case, the problem occurred after 4 Yarle output runs.

  • The .enex file used for testing
  • A set of files related to each of the four runs.

Later again... forget to mention...
a) When doing these test runs, all variables were left at default apart from changing the attachment directory options.
b) The reason I think that this is worth looking into, is that when importing a large set of notes spread over many notebooks, it is far more convenient to just step back to the "Select Enex files" page and choose the next batch of .enex files. Then step forward again to the "Convert" page and run the conversion. But if this stepping back process is causing issues, then the user has to do a fresh start for each batch.

@akosbalasko
Copy link
Owner

akosbalasko commented Feb 28, 2023

Hi @chookster !

Thank you for raising this issue! I checked the output logs, and it looks like that the note creation fails because the resources folder doesn't exists, but it should be, or it does exists (because of the previous runs) and the code tries to recreate it again.
Moreover it points to a problem around the UI too, because in the config I see these two options:

 "haveEnexLevelResources": true,
    "haveGlobalResources": true,

Which should be in xor, I mean only one of them should be true at most.
I just wanted to let you know the outcome of the investigation, I fix these problems soon.

Thank you very much!

@akosbalasko akosbalasko added the bug Something isn't working label Feb 28, 2023
@chookster
Copy link
Author

Which should be in xor, I mean only one of them should be true at most.
Good point. I forgot to mention this.

Also I forgot to mention, the end result of setting the following option to 'Yes', changed between 5.0.6 and 5.0.7.

Store attachments in notebook-level
( Store note resources on global _resources folder for each enex export)

In 5.0.6, setting this option to 'Yes' did create a single _resources folder for each enex export.
So

  • notebook1.enex
  • notebook2.enex
  • notebook3.enex
  • notebook4.enex

When exported into Obsidian as a batch created...

  • _resources
  • notebook1
  • notebook2
  • notebook3
  • notebook4

Which seemed to be the same as the Store all attachments in one folder option.

In 5.0.7, it now behaves differently. It creates a _resources sub-folder for each Evernote notebook or enex file.

  • notebook1
    • _resources
  • notebook2
    • _resources
  • notebook3
    • _resources
  • notebook4
    • _resources

I prefer the 5.0.7 version as it directly matches the option below in the Obsidian settings and you can continue using it once the notes arrive in Obsidian.

Default location for new attachments - In subfolder under current folder.

In Yarle, a suggestion for the wording underneath Store attachments in notebook-level is
( Store note resources in a subfolder of each enex file)

I hope this might help other users understand the outcome. I was very relieved when this change appeared in 5.0.7 as it is the end result I was trying to achieve.

@akosbalasko
Copy link
Owner

@chookster ,
good points, yeah, the expected behavior should be what is in 5.0.7 (this should be in 5.0.8 too).
Thank you for the wording, I'll add it in the next release, which will contain the fix for this issue.

@chookster
Copy link
Author

chookster commented Mar 1, 2023

Hi Akos, thanks for the speedy work in producing 5.0.8. It might take me a day or two to re-test it. Will post back after the tests are run.

@akosbalasko
Copy link
Owner

Hi @chookster ,
this issue has not been fixed yet, just the other one about the dots in the notebooks' name.
It is still open, i work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants