Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debuginfo-install: fix installing when installed version not found in repos, optimize performance (RhBug: 1108321) #32

Conversation

ignatenkobrain
Copy link
Contributor

… repos, optimize performance (RhBug: 1108321)
@akozumpl
Copy link
Contributor

I can see quite a few lint messages against debuginfo-install.py, many of those appearing only after this patch:

************* Module debuginfo-install
W0511: debuginfo-install:132,0: FIXME:
C0301: debuginfo-install:  2,0: Line too long (89/82)
C0301: debuginfo-install:133,0: Line too long (87/82)
C0301: debuginfo-install:136,0: Line too long (106/82)
C0301: debuginfo-install:137,0: Line too long (91/82)
C0103: debuginfo-install:  1,0: Invalid module name "debuginfo-install"
C0103: debuginfo-install: 68,4: Invalid argument name "p"
C0103: debuginfo-install: 94,4: Invalid argument name "po"
C0103: debuginfo-install: 94,4: Invalid argument name "r"
W0201: debuginfo-install: 59,8: Attribute 'packages_available' defined outside __init__
W0201: debuginfo-install: 60,8: Attribute 'packages_installed' defined outside __init__
W0201: debuginfo-install: 58,8: Attribute 'packages' defined outside __init__
W0201: debuginfo-install: 56,8: Attribute 'done' defined outside __init__
W0201: debuginfo-install: 57,8: Attribute 'rejected' defined outside __init__

Can you please fix those together with this rather large change? To run the pylint locally, use the ./scripts/lint <file.py>.

@akozumpl
Copy link
Contributor

Igor, I think I've missed your updated version. Is this still supposed to be merged?

@ignatenkobrain
Copy link
Contributor Author

Yes. This fixes some bugs and improves performance.

@akozumpl
Copy link
Contributor

merged now, thanks

@akozumpl akozumpl closed this Jul 23, 2014
@ignatenkobrain ignatenkobrain deleted the rhbz1108321 branch August 27, 2014 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants