Change decodeIp to only consider use up to byte Length bytes. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the issue where Ethernet packets must be a minimum of 60 bytes, but can take up only 54 bytes on the wire if there's no payload added. Without this change, packets of that type may appear to be TCP packets with 6 null bytes in their payload. See http://forums.devshed.com/networking-help-109/tcp-protocol-mysterious-6-null-byte-payload-303357.html for more discussion on this.
akrennmair
added a commit
that referenced
this pull request
Nov 23, 2011
Change decodeIp to only consider use up to byte Length bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue where Ethernet packets must be a minimum of 60 bytes, but
can take up only 54 bytes on the wire if there's no payload added. Without
this change, packets of that type may appear to be TCP packets with 6 null bytes
in their payload.
See
http://forums.devshed.com/networking-help-109/tcp-protocol-mysterious-6-null-byte-payload-303357.html
for more discussion on this.