Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed copy link issue #1614

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

Pranjalidhale0711
Copy link

Related Issue

Closes: #1600

Title: Add Functionality to Copy Button #1600

Description

This pull request introduces the functionality needed for the Copy button to properly copy the link to the clipboard, aligning with the expected behavior. Previously, the link was copied to the clipboard directly upon clicking the Share button, which was unintended.

Screenshots

Screenshot 2024-05-24 at 11 19 14 AM

Checklist

  • My code adheres to the established style guidelines of the project.
  • I have included comments in areas that may be difficult to understand.
  • My changes have not introduced any new warnings.
  • I have conducted a self-review of my code.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Pranjalidhale0711! 🎉 Thank you for submitting your pull request for Moksh. Our dedicated team will review it diligently.Your contribution is valuable and we appreciate your efforts to improve our project.

Copy link
Owner

@akshitagupta15june akshitagupta15june left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@akshitagupta15june akshitagupta15june merged commit ce90878 into akshitagupta15june:main Jun 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Clicking Copy Button Should Copy Link, Not Clicking Share Button
2 participants