Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar properties not working in v4 #1991

Closed
jaumebosch opened this issue Jul 8, 2017 · 11 comments
Closed

Navbar properties not working in v4 #1991

jaumebosch opened this issue Jul 8, 2017 · 11 comments
Labels

Comments

@jaumebosch
Copy link

jaumebosch commented Jul 8, 2017

Almost migrated to v4! great job!

but I'm unable to use this properties for navBar

drawerImage={require('../img/burger.png')} -> not working
navigationBarStyle={[STYLES.navBar]} -> this one works
navigationBarTitleImage={require('../img/logo.png')} -> not working
navigationBarTitleImageStyle={[STYLES.navBarLogo]} -> not working

@jaumebosch jaumebosch changed the title Navbar properties not working Navbar properties not working in v4 Jul 8, 2017
@aksonov
Copy link
Owner

aksonov commented Jul 9, 2017

@jaumebosch Thanks for the feedback. Will add these properties soon.

@aksonov aksonov added the bug label Jul 9, 2017
@jaumebosch
Copy link
Author

Keep informed, I'll do the testing :D

@aksonov
Copy link
Owner

aksonov commented Jul 9, 2017

And, of course, PR would be welcome if you want to speed up things. There is nothing difficult, you maybe check how other properties are passed.

For drawerImage you may set leftImage directly for now, you may check Example project.

@aksonov
Copy link
Owner

aksonov commented Jul 10, 2017

Please check latest beta.7

@jaumebosch
Copy link
Author

jaumebosch commented Jul 10, 2017

tested on beta7

navigationBarStyle={[STYLES.navBar]} -> working
navigationBarTitleImage={require('../img/logo.png')} -> working!!
navigationBarTitleImageStyle={[STYLES.navBarLogo]} -> working!!
drawerImage={require('../img/burger.png')} -> not working

Great job!

I've noticed on beta6 that the drawerImage import on navBar.js isn't used anywhere

@igorarkhipenko
Copy link

Seems like leftButtonTextStyle and backButtonTextStyle props don't work either. Can someone approve that?

@aksonov
Copy link
Owner

aksonov commented Jul 11, 2017

@jaumebosch drawerImage should work, I've just checked:
<Scene key="drawer" drawer contentComponent={TabView} drawerImage={require('./images/back_chevron.png')} >
I see 'chevron' instead of 'burger'
Maybe you didn't set it for drawer Scene but for inner tabs?

@jaumebosch
Copy link
Author

yep! I was setting once per scene, instead in the drawer scene.
Almost perfect!, but the icon is too low, is there any way to pass a "drawerImageStyle" ??

@aksonov
Copy link
Owner

aksonov commented Jul 11, 2017

Was it supported within v3? Maybe you could list other missed nav bar properties too there.

@jaumebosch
Copy link
Author

you're right
I've check again on V3 documentation and I can use "leftButtonIconStyle", which also applies to drawerImage

@jaumebosch
Copy link
Author

I think we can close it, everything resolved!

@aksonov aksonov closed this as completed Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants