Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggerFactoryExtensions is ambiguous #1

Closed
Trinition opened this issue May 1, 2018 · 1 comment
Closed

LoggerFactoryExtensions is ambiguous #1

Trinition opened this issue May 1, 2018 · 1 comment

Comments

@Trinition
Copy link

This project's clone of Microsoft.Extensions.Logging.LoggerFactoryExtensions collides with the one from Microsoft's package. I have code that is reflectively looking up a method in Microsft's LoggerFactoryExtensions class, but the compiler complains:

[CS0433] The type 'LoggerFactoryExtensions' exists in both 'Microsoft.Extensions.Logging.Abstractions, Version=2.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' and 'NHibernate.Extensions.Logging, Version=1.1.0.0, Culture=neutral, PublicKeyToken=null'

I don't think there's anything requiring your extension method class to have the same name, nor same namespace as Microsoft's. All that matters is that the type of the this parameter be Microsoft's LoggerFactory.

@akunzai
Copy link
Owner

akunzai commented May 18, 2018

Hi @Trinition,

I have rename the ambiguous extension method class at latest release.
thanks for your advice.

@akunzai akunzai closed this as completed Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants