Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecommerce dashboard #1754

Merged
merged 127 commits into from
Aug 8, 2018
Merged

Ecommerce dashboard #1754

merged 127 commits into from
Aug 8, 2018

Conversation

ESadouski
Copy link
Contributor

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

ESadouski and others added 30 commits February 6, 2018 00:50

constructor(private ordersChartService: OrdersChartService,
private profitChartService: ProfitChartService) {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary new line

list-item-border-width: 1px,

slide-out-container-width: 30%,
slide-out-background: linear-gradient(270deg, #f7fafb 0%, #ecf2f5 100%),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary space


import { ProfitChart } from '../../../../@core/data/profit-chart.service';

// TODO: need design, temporary solution
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved?

nb-theme(card-header-border-color);

.header {
margin-left: 1.1rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.1?

data: this.data,
},
],
})
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;

.echart {
position: absolute;
width: calc(50% - #{nb-theme(card-padding)});
height: calc(100% - 2 * #{nb-theme(card-padding)});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2? 😄

this.options = this.getOptions(variables);
const defaultSelectedData =
this.options.series[0].data.find((item) => item.name === this.defaultSelectedCurrency);
const color = defaultSelectedData.itemStyle.normal.color.colorStops[0].color;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

efaultSelectedData.itemStyle.normal.color.colorStops[0].color;

earningLiveUpdateCardData: LiveUpdateChart;
liveUpdateChartData: {value: [string, number]}[];
timeTicket: any;

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary line

* @type {{iconColor: string; title: string}[]}
*/
@Input()
legendItems: {iconColor: NgxLegendItemColor; title: string}[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{ }

}

ngOnDestroy() {
this.themeSubscription.unsubscribe();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alive

@nnixaa
Copy link
Collaborator

nnixaa commented Jul 26, 2018

Hey @dizco, this is a new dashboard we are working on, so if you have any comments - looking forward to it!

@dizco
Copy link
Contributor

dizco commented Jul 26, 2018

@nnixaa ohhh that sounds interesting! I'll check it out.

Nevermind my previous comment on here, I didn't know 😅

@dizco
Copy link
Contributor

dizco commented Jul 31, 2018

Hey @nnixaa, I checked it out and it looks really nice!! Definitely a few components that I should be able to reuse for my own project too.

Also something to think about could be a way to filter data, either by date interval or other... I know right now those filters are mostly on a per-card basis, but I'm wondering if that's really a main use case, versus filtering globally.

Just my 2 cents, great work

@nnixaa
Copy link
Collaborator

nnixaa commented Jul 31, 2018

@dizco hm, good idea, I believe we can somehow combine both per card and global date/time filters. Will save it as a possible enhancement.

nnixaa
nnixaa previously approved these changes Aug 8, 2018
@nnixaa nnixaa merged commit 56e4709 into akveo:master Aug 8, 2018
@DmytroLitvinov
Copy link
Contributor

Wow. New major release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants