Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tslint): add correct semicolon option #1777

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Conversation

eduhenke
Copy link
Contributor

@eduhenke eduhenke commented Jul 9, 2018

The first parameter in the semicolon option in tslint.json should be a boolean.

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

Fixes the typescript linter

The first parameter in the semicolon option in tslint.json should be a boolean.
@nnixaa
Copy link
Collaborator

nnixaa commented Jul 21, 2018

Hey @eduhenke, so is it correct that it wasn't working properly before this fix and now it checks for the semicolon presence?

@eduhenke
Copy link
Contributor Author

@nnixaa yep, exactly :)

@nnixaa
Copy link
Collaborator

nnixaa commented Jul 24, 2018

@eduhenke ah, good catch!

@nnixaa nnixaa merged commit 00e6ca5 into akveo:master Jul 24, 2018
nnixaa added a commit that referenced this pull request Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants