Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New nebular components #1911

Merged
merged 12 commits into from
Nov 19, 2018
Merged

Conversation

denStrigo
Copy link
Collaborator

Please read and mark the following check list before creating a pull request (check one with "x"):

Short description of what this resolves:

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. I don't think we need such a header on each new page:
    image
    We haven't got this header before. And I think the user will always know where is he because he becomes on this page by clicking on the menu item with the appropriate title.
    So, If you think these headers required, please, explain why.

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. I'm pretty sure we can position these showcases much better:)) so much free space now
    image

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. On the dialog page
    image
    Let's add more examples and let the user see the difference between enabled and disabled functionalities. I mean let's create cards with two buttons, for example: one for dialog with component another for dialog with template. One for dialog with backdrop, one without.
    What do you think?
    For now this page looks slightly messy, because we have only one button for each card.

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. The same thing for windows page
    image
    This page very similar to the existing one, I mean, modals, so, let's build it the same way.

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. May we add one more example on the chat ui page? So much space around
    image

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. so much space for each input, don't you think?
    image

@Tibing
Copy link
Member

Tibing commented Nov 14, 2018

  1. Also, I'm pretty sure we have to remove previous versions of showcases from the app. I mean modals in UI features and form inputs in forms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants