Menu show empty when remove data from it and its children

[TrungVuDang]

• I'm submitting a ...
  [x] bug report
  [ ] feature request
  [ ] question about the decisions made in the repository
• Do you want to request a feature or report a bug?
  This is bug
• What is the current behavior?
  For a menu, which I don't want to show on left menu, I did remove all "data" attribute from it and its children, but it still now the empty menu item.
• What is the expected behavior?
  It should not show any menu item which and its children don't have "data" attribute
• What is the motivation / use case for changing the behavior?
  I fixed it myself by add some line of code into baMenu.service.ts method _skipEmpty at line 36

 if (item.children && item.children.length > 0) {
          menuItem = this._skipEmpty(item.children);
          if (menuItem.length == 0){
            menuItem = null;
          }
        }

• Please tell us about your environment:
• Angular version: 2.0.0-rc.4
• Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)

[nnixaa]

Hi @TrungVuAnt, thanks for reporting, could you provide a PR for this fix? Thanks.

[TrungVuDang]

Hi @nnixaa, I intend to fix it, but I found if fix as I suggested, it will cause another issue: the page title and breadcrumb will show empty. That's because the left menu, the page title and the breadcrumb just show info from the "route->data->menu", I think, it should be separated, the menu, the page title, besides that, it also needs a way to show/hide menu depend on permissions of user.