Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

react@16.5.0 but i use react@17.0.2 #45

Open
gxanshu opened this issue Aug 23, 2021 · 8 comments
Open

react@16.5.0 but i use react@17.0.2 #45

gxanshu opened this issue Aug 23, 2021 · 8 comments

Comments

@gxanshu
Copy link

gxanshu commented Aug 23, 2021

馃挰 Question

Could not resolve dependency:
npm ERR! peer react@"16.5.0" from react-native-eva-icons@1.3.1

React Native Eva Icons Version

@samuelcbird
Copy link

I have the same problem. Is there a fix for this?

@agjini
Copy link
Contributor

agjini commented Dec 8, 2022

I've also the same problem with my project that use react 18.
For the moment we have to use --legacy-peer-deps flag on npm install.

I'm proposing a PR where I'm trying to solve the issue :

PR #46

@artyorsh
Copy link
Collaborator

The fix from @agjini resolves the issue, but for the sake of completeness I need to reinstall deps to regenerate yarn.lock - otherwise the codebase is not in actual state. I ignored it for a while, so now it will take time to bump dependencies and make sure everything, including example app, is runnable. I will post an update to NPM once this is done.

If you need a fix please either use --legacy-peer-deps or install the package from github

@agjini
Copy link
Contributor

agjini commented Dec 15, 2022

Hello @artyorsh and thanks for the explanation. Please let us know when the new version is published on npm.

@agjini
Copy link
Contributor

agjini commented Jan 5, 2023

Hi @artyorsh, any updates on npm publish ?

@artyorsh
Copy link
Collaborator

artyorsh commented Jan 6, 2023

Yep. I'm currently working on it in my free time, please understand. The progress so far: #47

It seems the only thing to fix is jest setup, something to do with config files. The rest seem to be running normally

@Mioriarty
Copy link

For me, the error still occured when I tried to build my expo app using expo's eas cli. I just wanted to share how I fixed the issue. It is pretty simple:

  1. Create a file named .npmrc in the root directory
  2. Write in that file the line legacy-peer-deps=true

I hope that helps some of you!

@SoloReverse
Copy link

On Expo projects, you could add the following in your package.json:

"scripts": { "eas-build-pre-install": "npm config set legacy-peer-deps true", },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants