Skip to content

Commit

Permalink
refactor(ui): drawer support component naming refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
32penkin committed Sep 24, 2019
1 parent 6bf8f4f commit 113822c
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 58 deletions.
41 changes: 11 additions & 30 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/framework/ui/drawer/drawer.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
Drawer,
DrawerProps,
} from '../drawer/drawer.component';
import { DrawerFence } from './drawerFence.component';
import { DrawerHeaderFooter } from './drawerHeaderFooter.component';
import {
MenuItemType,
MenuItem,
Expand Down Expand Up @@ -103,7 +103,7 @@ describe('@drawer: component checks', () => {

it('* should render header', () => {
const header = () => (
<DrawerFence testID='@drawer-header'/>
<DrawerHeaderFooter testID='@drawer-header'/>
);

const component: RenderAPI = renderComponent({ data, header, onSelect: () => 1 });
Expand All @@ -113,7 +113,7 @@ describe('@drawer: component checks', () => {

it('* should render footer', () => {
const footer = () => (
<DrawerFence testID='@drawer-footer'/>
<DrawerHeaderFooter testID='@drawer-footer'/>
);

const component: RenderAPI = renderComponent({ data, footer, onSelect: () => 1 });
Expand Down
18 changes: 0 additions & 18 deletions src/framework/ui/drawer/drawerFence.component.tsx

This file was deleted.

18 changes: 18 additions & 0 deletions src/framework/ui/drawer/drawerHeaderFooter.component.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import React from 'react';
import {
ListItem,
ListItemProps,
ListItemElement,
} from '../list/listItem.component';

export type DrawerHeaderFooterProps = Partial<ListItemProps>;
export type DrawerHeaderFooterElement = ListItemElement;

export class DrawerHeaderFooter extends React.Component<DrawerHeaderFooterProps> {

public render(): DrawerHeaderFooterElement {
return (
<ListItem {...this.props}/>
);
}
}
8 changes: 4 additions & 4 deletions src/framework/ui/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export {
DrawerHeaderElement,
} from './drawer/drawer.component';
export {
DrawerFence,
DrawerFenceElement,
DrawerFenceProps,
} from './drawer/drawerFence.component';
DrawerHeaderFooter,
DrawerHeaderFooterElement,
DrawerHeaderFooterProps,
} from './drawer/drawerHeaderFooter.component';
export {
Select,
SelectProps,
Expand Down
1 change: 1 addition & 0 deletions src/playground/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 7 additions & 3 deletions src/playground/src/navigation/drawerNavigation.component.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
DrawerProps,
MenuItemType,
Text,
DrawerFence,
DrawerHeaderFooter,
Icon,
Divider,
} from '@kitten/ui';
Expand Down Expand Up @@ -57,7 +57,8 @@ export class DrawerNavigation extends React.Component<DrawerItemsProps> {
private renderHeader = (): DrawerHeaderElement => {
return (
<React.Fragment>
<DrawerFence
<DrawerHeaderFooter
disabled={true}
title='UI Kitten'
description='Playground Module'
icon={this.renderIcon}
Expand All @@ -71,7 +72,10 @@ export class DrawerNavigation extends React.Component<DrawerItemsProps> {
return (
<React.Fragment>
<Divider/>
<DrawerFence description='Version 4.2.0'/>
<DrawerHeaderFooter
disabled={true}
description='Version 4.2.0'
/>
</React.Fragment>
);
};
Expand Down

0 comments on commit 113822c

Please sign in to comment.