Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 24 hour time with english language is not available #32

Closed
badener95 opened this issue Apr 20, 2023 · 6 comments
Closed

Use 24 hour time with english language is not available #32

badener95 opened this issue Apr 20, 2023 · 6 comments

Comments

@badener95
Copy link
Contributor

If the app language is set to auto or English the time is always displayed in am/pm. Because my language (German) is not available yet, I would like to keep using the app in English but with 24 hour time. I believe this was possible in the past, but I can't remember with version of the app has changed that.

@badener95 badener95 changed the title Use 24 hour time with english language Use 24 hour time with english language is not available Apr 20, 2023
@farfromrefug
Copy link
Collaborator

@badener95 great idea will add the option

@farfromrefug
Copy link
Collaborator

@badener95 BTW if you translate that file values to German and share it with me I can easily add support for it
https://github.com/Akylas/oss-weather/blob/master/app/i18n/en.json

@badener95
Copy link
Contributor Author

Thanks for the quick implementation! I will translate the strings as soon as I find some time to do it.

@farfromrefug
Copy link
Collaborator

@badener95 I forgot to tells you. Normally you don't need to use the 24 hour format option in the app. By default the app use the value of the system 24 hour format option. Have you that turned on?

@badener95
Copy link
Contributor Author

My device is set to 24 hour format, but that did not work for me. Only when the app language was manually switched to Spanish or French the time was shown in 24 hour format, but then I can't understand the forecast.
My device is a Google Pixel 4a with android 13.

@farfromrefug
Copy link
Collaborator

@badener95 OK that s a bug then ! Will try to fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants