Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make the core feature work #5

Merged
merged 1 commit into from
Nov 5, 2022
Merged

fix: Make the core feature work #5

merged 1 commit into from
Nov 5, 2022

Conversation

flub
Copy link
Contributor

@flub flub commented Nov 4, 2022

Updating the support for the core feature to compile and be compatible on the API.

Also deletes some unused fields and methods the compiler was complaining about and cargo-fmt made some changes to the edited files.

We don't particularly need the core feature, however it is the only way to use the crate without depending on default features of the chrono crate. And the chrono crate has a dependency on a vulnerable version of the time crate. Switching to the core feature for this crate allows us to avoid having the vulnerability in our dependencies.

Updating the support for the core feature to compile and be compatible
on the API.

Also deletes some unused fields and methods the compiler was
complaining about.
@al8n al8n merged commit 77ad5c5 into al8n:main Nov 5, 2022
@flub
Copy link
Contributor Author

flub commented Nov 5, 2022

Thanks! Any chance of publishing a new release with this?

@al8n
Copy link
Owner

al8n commented Nov 12, 2022

Thanks! Any chance of publishing a new release with this?

Sorry, I forgot to release it. I will do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants