Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16.5 Compat bug] Using Controllable to grab a ledge causes "wriggling" and cannot be followed up by a jump #136

Open
Kaleidio opened this issue Feb 5, 2023 · 3 comments
Open

[1.16.5 Compat bug] Using Controllable to grab a ledge causes "wriggling" and cannot be followed up by a jump #136

Kaleidio opened this issue Feb 5, 2023 · 3 comments
Labels
bug Something isn't working compatibility request Requests to add a compatibility with mods controller About controller support

Comments

@Kaleidio
Copy link

Kaleidio commented Feb 5, 2023 •
edited

Summary
Issue is in the title. The "wriggling" animation is the torso of the player's model animating rapidly because of the spammed input

Running Environment

  • Minecraft Version: 1.16.5
  • ParCool Version: 2.1.0.0-R
  • Forge Version (optional): 36.2.39

Detail
This issue is arising because controllable spams inputs that are held, rather than having an available held state to read from. Consider implementing a custom flag check instead of relying on the input classes isHeld method.

More than likely affects all available versions
@Kaleidio Kaleidio added the bug Something isn't working label Feb 5, 2023
@Kaleidio
Copy link
Author

Kaleidio commented Feb 5, 2023

Issue serves as extension to #129 and is not a duplicate

@Kaleidio Kaleidio changed the title [1.16.5 Compat bug] Using controllable to grab a ledge causes "wriggling" and cannot be followed up by a jump [1.16.5 Compat bug] Using Controllable to grab a ledge causes "wriggling" and cannot be followed up by a jump Feb 5, 2023
@alRex-U
Copy link
Owner

alRex-U commented Feb 6, 2023

Thank-you for reporting.

I maybe will do controller support but it may take times.

@alRex-U alRex-U added the controller About controller support label Feb 23, 2023
@shuu-shu
Copy link

shuu-shu commented Apr 5, 2023

yes please (:

@alRex-U alRex-U added the compatibility request Requests to add a compatibility with mods label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compatibility request Requests to add a compatibility with mods controller About controller support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kaleidio @alRex-U @shuu-shu