Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncompatibility Issue between ParCool and Better Combat in Recent Versions 1.20.1 #243

Open
HeyRicar opened this issue Apr 6, 2024 · 3 comments
Labels
bug Something isn't working compatibility request Requests to add a compatibility with mods

Comments

@HeyRicar
Copy link

HeyRicar commented Apr 6, 2024

I would like to inform you about an incompatibility issue I have encountered between ParCool and Better Combat in the latest versions of Minecraft. While they were previously compatible, attempting to use both mods now results in an error that affects the gaming experience. When performing parkour movements alongside Better Combat's combat mechanics, the game becomes unstable, leading to a bug. I have attached a video clearly demonstrating this issue. I would appreciate it if you could investigate this compatibility problem and find a solution.

Error.parcool.mp4
@HeyRicar HeyRicar added the bug Something isn't working label Apr 6, 2024
@HeyRicar HeyRicar changed the title ncompatibility Issue between ParCool and Better Combat in Recent Versions ncompatibility Issue between ParCool and Better Combat in Recent Versions 1.20.1 Apr 6, 2024
@alRex-U
Copy link
Owner

alRex-U commented Apr 8, 2024

As for this problem actually I may know why this is caused.

In legacy versions FastRun animation doesn't apply animation to players arm.
But since 3.2.0.1 it does so it may overwrite better combat animation. I think

If so this is just a problem of priority. The simplest solution is decrease priority of ParCool animation (I am sure that Forge should have such API) but this can cause other incompatibilities...

@alRex-U alRex-U added the compatibility request Requests to add a compatibility with mods label Apr 8, 2024
@zaeonNineZero
Copy link

zaeonNineZero commented Apr 12, 2024

Better Combat uses the playerAnimator mod for its animations, so you might be able to use that to detect if an animation is in progress. For this particular issue: detect if an attack animation from Better Combat is in progress, and if so, don't render the Fast Run animation until the attack animation ends.

EDIT: This is also the same issue as #233 and I can confirm that it's present on 1.19.2 as well. I imagine it's an issue that exists across every MC version, and dates back to the v3.1.0.0 releases.

@panqueka
Copy link

Better Combat usa o mod playerAnimator para suas animações, então você pode usá-lo para detectar se uma animação está em andamento. Para este problema específico: detecte se uma animação de ataque do Better Combat está em andamento e, em caso afirmativo, não renderize a animação Fast Run até que a animação de ataque termine.

EDIT: Este também é o mesmo problema do nº 233 e posso confirmar que também está presente no 1.19.2. Imagino que seja um problema que existe em todas as versões do MC e remonta aos lançamentos v3.1.0.0.

How could I do this? I'm having problems because of this mod incompatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility request Requests to add a compatibility with mods
Projects
None yet
Development

No branches or pull requests

4 participants