regression: <C-Tab> keybinding no longer works

[sodiumjoe]

Which operating system does the issue occur on? macos 10.10.5

If on linux, are you using X11 or Wayland? n/a

the specific keybinding is:

  - { key: Tab,      mods: Control, chars: "\x01n",                      }

git bisect points at this commit, which is just an upgrade of glutin/winit.

I haven't really figured out whether it's an issue with an upstream breaking change or what. Running winit's window example, I can see the event come through on the keypress:

WindowEvent { window_id: WindowId(Id(140330957578608)), event: KeyboardInput { device_id: DeviceId(DeviceId), input: KeyboardInput { scancode: 48, state: Released, virtual_keycode: Some(Tab), modifiers: ModifiersState { shift: false, ctrl: true, alt: false, logo: false } } } }

A println here also does show the event coming through, so maybe it has something to do with config parsing or something. I'm going to continue investigating, but wanted to make an issue in case anyone has ideas.

[snoblenet]

related to this? #1336

[sodiumjoe]

this was fixed in winit in rust-windowing/winit#629

[chrisduerr]

Once winit's cargo version is updated I'll run cargo update on the #1403 PR so it will resolve this problem.

Thanks for the update @sodiumjoe.

[sodiumjoe]

@chrisduerr I think we'll have to get it into glutin first, right?

[chrisduerr]

@sodiumjoe Not if it's just a semver patch (or minor after 1.0). So if glutin says it just wants 0.6.0, then everything until 0.7.0 should be viable.

[sodiumjoe]

oh great! hm, I guess I need to review my understanding of cargo