Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup mode Maximized with none decorations cause fullscreen on Windows #3784

Open
codehz opened this issue May 28, 2020 · 11 comments
Open

Comments

@codehz
Copy link

codehz commented May 28, 2020

For bug reports, the following information can help speed up the process. Please describe the bug that you have found and what you would expect to happen instead.

System

OS: Windows
Version: v0.4.3-rc1
Windows: ConPTY (also for WinPTY)

Logs

[2020-05-28 21:51:14.808682000] [INFO] Welcome to Alacritty
[2020-05-28 21:51:14.808682000] [INFO] Configuration loaded from "C:\Users\CodeHz\AppData\Roaming\alacritty\alacritty.yml"
[2020-05-28 21:51:14.880889000] [INFO] Device pixel ratio: 1.25
[2020-05-28 21:51:14.889035200] [INFO] Initializing glyph cache...
[2020-05-28 21:51:14.913584800] [INFO] ... finished initializing glyph cache in 0.0243273s
[2020-05-28 21:51:14.914603200] [INFO] Cell Size: 10 x 25
[2020-05-28 21:51:14.921805400] [INFO] Padding: 2 x 9
[2020-05-28 21:51:14.921805400] [INFO] Width: 1024, Height: 768
[2020-05-28 21:51:14.953070100] [INFO] PTY Dimensions: Line(30) x Column(102)
[2020-05-28 21:51:14.953070100] [INFO] Using WinPTY backend
[2020-05-28 21:51:15.095485000] [INFO] Initialisation complete
[2020-05-28 21:51:15.111089300] [INFO] Width: 1920, Height: 1080
@kchibisov
Copy link
Member

And how it looks with decorations? Also, does Alt + Enter unfullscreens it or it just does nothing on a first press? I don't have Windows system to test how maximize works on it.

@codehz
Copy link
Author

codehz commented May 28, 2020

with decorations: normal maximized
Alt + Enter twice : normal maximized (so the first alt + enter is switch to real fullscreen mode

@kchibisov
Copy link
Member

What are you expecting from maximized window without decorations? I'll assume it should just look like a fullscreen window, and from what you describe it's just a normal window, but big.

so the first alt + enter is switch to real fullscreen mode

it's not fullscreen window. Could you show me a screenshot of normal maximized window? I'll assume that it doesn't cover dock/statusbar, right?

@codehz
Copy link
Author

codehz commented May 28, 2020

Could you show me a screenshot of normal maximized window?

image

that's expected (after alt-enter twice)

but actually

image

(combine with another bug that the vim cannot recognize the size of maximized window before resize

@kchibisov
Copy link
Member

(combine with another bug that the vim cannot recognize the size of maximized window before resize

It's a known vim/nvim bug (not our bug). It can't handle multiple resizes during starturp due to some "reasons".

@codehz
Copy link
Author

codehz commented May 28, 2020

It's a known vim/nvim bug (not our bug)

nope, it also happened to bash (after I try to execute more than N command that will exceed to the limit, the behavior is weird
image

(and it is hard to repro, just randomly....(maybe 10%)
i think there are some race conditions

@codehz
Copy link
Author

codehz commented May 28, 2020

that's expected (after alt-enter twice)

(nope, the last line is behind of the taskbar...

@chrisduerr
Copy link
Member

the last line is behind of the taskbar

So it's not actually fullscreen, but it's just too big?

@codehz
Copy link
Author

codehz commented May 28, 2020

but it's just too big

yes, just like some game's seamless window mode

@chrisduerr
Copy link
Member

Reported upstream in rust-windowing/winit#1582.

@tinnick
Copy link

tinnick commented Jan 16, 2021

Hey guys, I have the same problem.

Just so you know it's not only this person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants
@chrisduerr @codehz @kchibisov @tinnick and others