Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: should output the correct configs & rules #5

Merged
merged 5 commits into from Feb 9, 2019
Merged

Fix: should output the correct configs & rules #5

merged 5 commits into from Feb 9, 2019

Conversation

aladdin-add
Copy link
Owner

No description provided.

g-plane
g-plane requested changes Feb 9, 2019
View reviewed changes
Copy link
Collaborator

@g-plane g-plane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the structure of configAll is wrong. The object should contain the rules property, and all the rules-related config should be in this rules field, not in configAll directly.

lib/configs/all.js Outdated Show resolved Hide resolved
@aladdin-add
Copy link
Owner Author

good catch! pushed a new commit to fix it.

@aladdin-add aladdin-add merged commit 5e1d360 into master Feb 9, 2019
@aladdin-add aladdin-add deleted the fix/configs branch February 9, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-plane g-plane g-plane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aladdin-add @g-plane