Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom attributes #106

Conversation

laurentverbruggen
Copy link

In my use case I have a necessity to add custom attributes dynamically to allow publishing Spring Rest Docs (with generated snippets) to Confluence. I replace the {snippets} attribute with the correct path to the generated snippets and they are properly included. Changes in this pull request allow adding the custom {snippets} attribute.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 85.632% when pulling c55f6cf on laurentverbruggen:feature/custom-attributes into 8a6e593 on alainsahli:master.

@znerd
Copy link
Contributor

znerd commented Feb 27, 2019

@laurentverbruggen This seems like a useful feature. Would you be able to provide tests as well, to implement test coverage?

@cstettler
Copy link
Member

@laurentverbruggen I am closing this stale pull request, feature has been re-implemented by @Aloren via #139.

@cstettler cstettler closed this Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants