Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for internal cross-references #117

Merged
merged 1 commit into from
Feb 26, 2019
Merged

Support for internal cross-references #117

merged 1 commit into from
Feb 26, 2019

Conversation

cstettler
Copy link
Member

@cstettler cstettler commented Nov 27, 2018 •
edited
Loading

See "Links within Pages" in documentation section

Resolves #21 and #116

@cstettler cstettler mentioned this pull request Nov 27, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.353% when pulling 1b42a9a on feature/internal-cross-references into 8a6e593 on master.

@znerd
Copy link
Contributor

znerd commented Jan 3, 2019 •
edited
Loading

There are no unit tests added in the PR yet. Would be good to have unit tests that would have failed before (with a StringIndexOutOfBoundsException, see #21 and #116), but now succeed.

Update: Sorry, overlooked them; there are tests.

@cstettler cstettler added this to the 0.5.0 milestone Feb 26, 2019
@cstettler cstettler merged commit 08e214b into master Feb 26, 2019
@cstettler cstettler removed the feature label Feb 26, 2019
@cstettler cstettler removed this from the 0.5.0 milestone Feb 26, 2019
@cstettler cstettler deleted the feature/internal-cross-references branch March 4, 2019 19:33
@adpriebe adpriebe mentioned this pull request May 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znerd znerd znerd approved these changes

@alainsahli alainsahli alainsahli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cstettler @coveralls @znerd @alainsahli