Integration of PR #102 (Implement REPLACE_ANCESTOR publish strategy) #122
Conversation
…sting pages (involved changing ancestor id parameter for update page request to optional, as with replace-ancestor publishing strategy, ancestor of root page should never be changed)
… changed (only relevant in replace-ancestor publishing strategy)
...rc/main/java/org/sahli/asciidoc/confluence/publisher/client/metadata/PublishingStrategy.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/sahli/asciidoc/confluence/publisher/client/ConfluencePublisher.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/sahli/asciidoc/confluence/publisher/client/ConfluencePublisher.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/sahli/asciidoc/confluence/publisher/client/ConfluencePublisher.java
Outdated
Show resolved
Hide resolved
...client/src/main/java/org/sahli/asciidoc/confluence/publisher/client/ConfluencePublisher.java
Outdated
Show resolved
Hide resolved
|
@garretfick this PR (including the changes from #102) is now merged and available in the current snapshot build. Note: when (or before) adding new publishing strategies, some refactoring on the implementation of the publishing strategies (i.e. turn the enum-based switch statement into a real strategy pattern) will probably be helpful. Using your requirements mentioned in #102 (comment) would for sure be a good driver for the right abstraction of such a publishing strategy interface. Also, (in a later step) we should think about allowing configuring custom new publishing strategy implementations during runtime (e.g. using dynamic configuration properties in the maven plugin and lookup of the implementation via the service loader API or the like). |
Resolves #76, implemented by @laurentverbruggen in PR #102