Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International Dates Cause App to Skip File #17

Open
Alamantus opened this issue Jan 12, 2022 · 2 comments
Open

International Dates Cause App to Skip File #17

Alamantus opened this issue Jan 12, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@Alamantus
Copy link
Owner

Alamantus commented Jan 12, 2022

The Organize process makes several checks to validate the photoTakenDate in the file's .json metadata. Unfortunately, the app was only built with English in mind, but Google allows exporting in the user's native language, which means that JavaScript's new Date() parsing fails on anything that isn't English, causing the app to skip the file because it couldn't be validated. How charming!

To fix this, I'll need to find a date parsing library that can handle any language. This will go hand-in-hand with issue #13.

@Alamantus Alamantus added the help wanted Extra attention is needed label Jul 14, 2022
@omia
Copy link

omia commented Mar 9, 2023

Just out of curiosity.
Why don't you use the timestamp?
photoTakenTime = meta.photoTakenTime.timestamp; const date = new Date(photoTakenTime*1000);

@Alamantus
Copy link
Owner Author

I'll have to get a copy of an export again to see if timestamp is consistently provided on photoTakenTime, but if it is (or always has been), then that sounds like an excellent idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants