Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need an icon on each event #243

Closed
jkhanknysys opened this issue Dec 31, 2015 · 7 comments
Closed

Need an icon on each event #243

jkhanknysys opened this issue Dec 31, 2015 · 7 comments

Comments

@jkhanknysys
Copy link

Hi I am trying to add different set of icons in each event. can you tell me how can I do that?
screenshot from 2015-12-31 15 29 20

@entropitor
Copy link
Contributor

That's currently not possible. I guess you'll have to adapt the library for that. (The library is rather simple, so it should probably be straightforward).

@Tolriq
Copy link

Tolriq commented Jan 1, 2016

If I may this is currently the biggest problem of the library and reason for many fork and many duplicate work.

If I had more time I'd propose a PR but I guess as most it's easier to fork / modify than modify the core.

Anyway the problem is that library is too much tied between WeekViewEvent and the view.

There's no proper way to add fields to this and modify the display without a fork :(

What would be wonderful is that the WeekViewEvent is more abstract with some copy methods to handle multidays events.

And separate the event drawing code into things that can be overridden easily.

Personally I'd go to at least 2 methods, a method that draw the background / color (that most won't override) and a method to fill the said rectangle passing a clipped canvas for example.

@entropitor
Copy link
Contributor

@Tolriq The problem is that nodoby on this project really has to time to do implement this. While this is indeed one of the biggest flaws of the library, somebody from the community is going to have to stand up to implement it.

@Tolriq
Copy link

Tolriq commented Jan 1, 2016

Well I may try in future as I'll have more needs, but it will be API 14+ so not sure you'll accept things like that.

@entropitor
Copy link
Contributor

I think we need to contact @alamkanak too for that decision.

But wouldn't it possible to have a backwardscompatible version so that 14+ is customizable and 14- is not?

@Tolriq
Copy link

Tolriq commented Jan 1, 2016

Everything is possible but as my time is quite limited I won't have time to test / maintain this backward compat so will not propose it if the PR comes from me sorry.

@entropitor
Copy link
Contributor

I'm gonna close this one in favor of #217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants