Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe operations are not tested #253

Closed
tlienart opened this issue Oct 7, 2019 · 1 comment
Closed

Pipe operations are not tested #253

tlienart opened this issue Oct 7, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@tlienart
Copy link
Collaborator

tlienart commented Oct 7, 2019 •
edited

The feature that we added in 0.5 to make this kind of syntax possible:

W = Xs |> Standardizer()
z = ys |> UnivariateBoxCoxTransformer()
# "second layer"
ẑ = (W, z) |> RidgeRegressor(lambda=0.1)

is actually untested (no call to operations.jl in runtests.jl).

Unfortunately this would have shown us that the syntax does not seem to work as it should as of now. I'm happy to try to fix this but I first need #252 fixed
@tlienart tlienart added the bug Something isn't working label Oct 7, 2019
@ablaom ablaom mentioned this issue Oct 7, 2019
Closed
6 tasks
@tlienart tlienart mentioned this issue Oct 9, 2019
Merged
@tlienart
Copy link
Collaborator Author

now they are

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tlienart