Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for fit! #24

Merged
merged 1 commit into from Apr 6, 2020
Merged

Tests for fit! #24

merged 1 commit into from Apr 6, 2020

Conversation

ayush-1506
Copy link
Member

Fixes: #22

@ayush-1506 ayush-1506 requested a review from ablaom April 6, 2020 02:59
ablaom
ablaom reviewed Apr 6, 2020
View reviewed changes
test/core.jl

# Loss should decrease at every epoch
@test history == sort(history, rev=true)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clever

@ablaom ablaom merged commit ef58384 into master Apr 6, 2020
@DilumAluthge DilumAluthge deleted the fit_test branch April 15, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for fit!(chain...)
2 participants
@ayush-1506 @ablaom