Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fit by build #42

Merged
merged 1 commit into from Jun 9, 2020
Merged

Replace fit by build #42

merged 1 commit into from Jun 9, 2020

Conversation

ayush-1506
Copy link
Member

Fixes: #40

@ayush-1506 ayush-1506 mentioned this pull request Jun 9, 2020
Closed
@ayush-1506 ayush-1506 requested a review from ablaom June 9, 2020 05:28
ablaom
ablaom approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please update the readme and then merge, thanks.

I'm finished for today.

@ayush-1506 ayush-1506 merged commit 5c87996 into master Jun 9, 2020
@ayush-1506 ayush-1506 deleted the build branch June 9, 2020 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ablaom ablaom ablaom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name change fit(builder, ...) to chain(builder,...) ?
2 participants
@ayush-1506 @ablaom