For a 0.4.0 release #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove unsafe use of dictionary in multithreading
Also trys avoids serializing by removing fetch
Avoids boxing of progressmeters and channels in learning curve generation
|
It appears from comments above that #57 (breaking) is required before this one. If so, can you please re-title this PR, reminding me what this PR does (remove dictionaries ?) |
|
Nevermind, I forgot this is already the dev branch. I'm going to merge this and #57 and just live with the extra breaking release. I have other updates I want to make here. |
Created a copy of range object for each thread since in general the user is allowed to define a more general range type(`<:MLJBase.Param`) which may behave much differently(e.g may be mutable) creating unwanted side effects.
|
@OkonSamuel Good catch, although I should not think a good idea (or good reason?) to have mutating range objects, and could add that to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPUProcesseswithinCPUThreads(breaking)